Karol, See below for my comments, some of them may duplicate comments from other people though ...
Paul karol wrote: > > I'm working on porting package "iperf" to opensolaris, which is for > measuring max TCP/UDP bandwidth performance. > > Could you help to review it? > > http://cr.opensolaris.org/~lxin/iperf/ === Start of Comments === 1. usr/src/cmd/iperf/METADATA Make the NAME: field more descriptive 2. usr/src/cmd/iperf/Makefile.sfw Roland Mainz wrote: > Use "env - ..." and not "env ..." in the Makefiles to > make sure "configure"&&"make" only see the env variables > they should really get (and not pick-up any random env > variable) > Use either $(SHELL) or /usr/bin/bash for "configure" > calls (so we know which one is used and "configure" > doesn't pick one itself) What compiler are you using to build this ? Could the move the applying of the patch ... 34 /usr/bin/gpatch -p1 < ../iperf-2.0.4-pthreads-rt.patch into the '$(VER)/configure:' rule? (or $(VER)/config.status) 3. usr/src/cmd/iperf/install.sfw This file would normally be named install-sfw Line .. 43 _install N ${PKGDIR}/man/iperf.1 .... use '_install M ...' so it adds the sunman-stability stuff 4. usr/src/pkgdefs/SUNWiperf/depend Move the Copyright lines to after the 'CDDL HEADER END' header This looks like the default set of dependencies, have you checked you have no others with the gate's dependency checker script ? If there are no others, delete this file and add DATAFILES= depend into SUNWiperf/Makefile 5. usr/src/pkgdefs/SUNWiperf/pkginfo.tmpl Add version at the end of the DESC= line, eg DESC="iperf - .......... (2.0.4)" === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
