Hi Jim and team, I have passed the i-team code review & ARC review already.
Before going onto the c-team review step, I did a full functional testing for SUNWpatchutils, and found some issues(bug/dependency) 1. Most utilities in this package handle patch files with gpatch & gdiff, so we need to add two more packages into the depend file, as follows: ... P SUNWgnu-diffutils GNU diffutils P SUNWgpch The GNU Patch utility 2. I found a bug that the getline() function in the file src/util.c provided for non-GNU systems can't handle NUL character properly. For example: [nl219604 at skyvoice tmp] $ echo -e "abc\0" > file1 [nl219604 at skyvoice tmp] $ echo "abc" > file2 [nl219604 at skyvoice tmp] $ gdiff -au file1 file2 > diff1 [nl219604 at skyvoice tmp] $ cat -v diff1 --- file1 2009-02-16 18:12:15.208180647 +0800 +++ file2 2009-02-16 18:12:24.246282178 +0800 @@ -1 +1 @@ -abc^@ +abc [nl219604 at skyvoice tmp] $ /usr/bin/filterdiff diff1 2>errors >diff2 [nl219604 at skyvoice tmp] $ cat -v diff2 --- file1 2009-02-16 18:12:15.208180647 +0800 +++ file2 2009-02-16 18:12:24.246282178 +0800 @@ -1 +1 @@ -abc+abc So it can't output the newline character because of the previous NUL character. I have fixed the bug, and generated the related patch file. 3. There's an existing test suite in the package tarball, but some changes need to be made to make to work on solaris. Now all 126 test cases in the test suite behave as expected. Should I also generated the patch files for the test suite? The updated webrev is located at: http://cr.opensolaris.org/~jason_li/patchutils/ The updated the ARC materials are located at: http://greatwall.prc/~nl219604/package_porting/PSARC_materials/ Pls let me know if I can more onto the C-team review step. -Jason
