I will mail you back once the modifications are done on all those files. I've built and tested it.
Thanks Spoorthy Paul Cunningham wrote: > Spoorthy, > > See below for my comments ... > > Paul > > Spoorthy H.S wrote: >> >> I am porting 'conman'. ConMan is a Console Management program. More >> info on the tool can be found at http://home.gna.org/conman/ >> >> Webrev is at http://cr.opensolaris.org/~spoorthy/conman2/ > > === Start of Comments === > > 0. Have you built and tested this?? > If not please do not request another review until you have. > > 1. usr/src/cmd/conman/METADATA > Please add the missing fields, see ... > http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines > > 2. usr/src/cmd/conman/Makefile.sfw > Do you need the line ... > 22 # /* Portions Copyright 2007 */ > > Change ... > 50 (cd $(VER); env \ > to ... > (cd $(VER); env - \ > > Lines ... > 29 VER=conman-0.2.3 > 30 TARBALL = $(VER).tar.gz > extract the VER= info from the METADATA, see recent > integrations for examples. > > Change '/usr/sfw/bin/gtar' to $(GTAR) from Makefile.master > > Why 'env env' ... > 50 (cd $(VER); env \ > 51 env ac_cv_sys_long_file_names=yes \ > > 3. usr/src/cmd/conman/install-sfw > Pass the VERS= info into script from Makefile.sfw as > environment var or as an option. > > Delete line ... > 52 #_install E conmen .... > > Copyright year is wrong > > Delete line .. > 23 # /* Portions Copyright ... > > Change ... > Roland Mainz wrote: > > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > > and add a $ set -o errexit # at the beginning and > > replace ". ${SRC}/tools/install.subr" with > > "source ${SRC}/tools/install.subr" (the idea is to > > catch failures in the script and abort it at that point, > > right now the script will just continue) > > 4. usr/src/cmd/conman/conman.1 > & usr/src/cmd/conman/conman.conf > & usr/src/cmd/conman/conmand.xml > & usr/src/cmd/conman/svc-conmand > Did you write these, if so they should probably have the > CDDL HEADER stuff added. > And add the Sun Copyright lines. > > > 5. usr/src/pkgdefs/SUNWconman/pkginfo > Delete this file from your ws (so it doesn't show up in > the webrev) as its generated from pkginfo.tmpl > > 6. Portions Copyright lines in various files > You should probably delete these lines > > 7. Copyright year lines in various files > You need to correct these in various files > > 8. usr/src/pkgdefs/Makefile > Have you changed this to add your pkg names > > 9. CDDL HEADER and top of files > You may want to change all the files so that they conform > to that in ... > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; > > (see http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines) > > 10. usr/src/pkgdefs/SUNWconman/copyright > Add the the pkg originator copyrights at the top? See .. > http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright > > > 11. usr/src/pkgdefs/SUNWconman/depend > This looks like the default depend file! > Have you checked you have no other dependencies with the > gates dependency checker script? If there are none > then delete this files and add 'DATAFILES = depend' to > your SUNWconman/Makefile. If there are other dependencies > Then add them here; and also move the Copyright lines to > after the CDDL HEADER END header (see (9)) > > 12. SCCS ident lines in files > These looks wrong, ie. a direct copy of what was in > the files you copies originally - so you need to fix them > appropriately with sccs ident stuff > > 13. usr/src/pkgdefs/SUNWconman/pkginfo.tmpl > Change DESC= line to ... > DESC="conman - Console Manager (0.2.3)" > > 14. usr/src/pkgdefs/SUNWconman/prototype_com > The following /etc/* stuff ... > 87 d none etc 0755 root sys > 88 f none etc/conman.conf 0744 root sys > 89 d none etc/default 0755 root sys > 90 f none etc/default/conman 0744 root sys > 91 d none etc/init.d 0755 root sys > 92 f none etc/init.d/conman 0744 root sys > 93 d none etc/logrotate.d 0755 root sys > 94 f none etc/logrotate.d/conman 0744 root sys > should be in its own 'root' package, eg. SUNWconmanr, > so you need to add another package and then this pkg > will probably depend on the new pkg. > > What is the = for ... > 47 f none usr/bin/conman= 0555 root bin > > === End of Comments =====
