John Leser wrote: > Hello again, > > Sorry, my first webrev was not reachable by folks outside of Sun. I've > moved it here: > > http://cr.opensolaris.org/~jleser/nano-2009.02.21 > > There was also one small change: I'm not including the file > /usr/share/info/dir in the common package prototype. >
This file has the correct CDDL and Copyright block format. Update all the files that use the CDDL header with this format. http://cr.opensolaris.org/~jleser/nano-2009.02.21/usr/src/cmd/Makefile.html usr/src/cmd/nano/METADATA - use this format: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/METADATA.html usr/src/cmd/nano/Makefile.sfw - make it look more like this: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/Makefile.sfw.html - note CCSMAKE should be used everywhere include install target - note "env -" should be used - rm core can be removed usr/src/cmd/nano/install-sfw - make it look more like this: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/install-sfw.html - note ksh93 should be used - set -o errexit should be aded - "source" instead of "." should used - _install should be used usr/src/pkgdefs/SUNWgnu-nano/depend - since nano is using standard dependences and the make file has: 28 DATAFILES = depend, which uses workspace standard depend file - you can removed the nano depend file usr/src/pkgdefs/SUNWgnu-nano/prototype_com - put the directories and files in alphabetical order usr/src/pkgdefs/SUNWgnu-nano/prototype_i386 usr/src/pkgdefs/SUNWgnu-nano/prototype_sparc http://cr.opensolaris.org/~lxin/iperf/usr/src/pkgdefs/SUNWiperf/prototype_i386.html Cheers, Jim
