Siwei, This mainly looks good to me, see comment below from my quick skip through ...
Paul Si-wei Louis Liu wrote: > > I am working on porting the package aget. Aget is a multi-threaded HTTP > download accelerator. > > Several helpful info for code review: > 1) Aget has no man page, so there's a aget.1 which is newly created by me. > 2) Aget defines its own license file contained in the tarball (see its > COPYING file). The license is BSD like. Basically Aget has already been > ported to several *BSD OSes, and Linux as well. > > Can someone help review the integration into sfwnv? Webrev is here: > http://cr.opensolaris.org/~swliu/aget === Start of Comments === 1. usr/src/pkgdefs/SUNWaget/depend This looks like the default 'depend'. have you check u have no the dependencies (with gate's pkg dependency checker script)? If no others delete this file and add "DATAFILE = depend" to your SUNWaget/Makefile. Otherwise add the other dependencies === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
