Srirama, This looks mainly good to me :-) Just a couple of comments, see below ...
Paul Srirama Sharma wrote: > > Requesting a code review for Openwsman. > > Openwsman is a project intended to provide an open-source implementation > of the Web Services Management specification (WS-Management) and to > expose system management information on the underlying operating system > using the WS-Management protocol. > > Webrev: http://cr.opensolaris.org/~srirama/openwsman/ > Bug: http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6797968 1. usr/src/pkgdefs/SUNWopenwsmanr/depend & usr/src/pkgdefs/SUNWopenwsmanu/depend Shouldn't SUNWopenwsmanu depend on SUNWopenwsmanr, rather than SUNWopenwsmanr depending on SUNWopenwsmanu? If that is the case then you don't need SUNWopenwsmanr/depend and so you can add "DATAFILES = depend" into SUNWopenwsmanr/Makefile so it uses the default one 2. usr/src/pkgdefs/SUNWopenwsmanr/copyright & usr/src/pkgdefs/SUNWopenwsmanu/copyright You could concatenate the lines ... 5 Copyright (c) 1988, 1993 The Regents of .... 6 Copyright (c) 1990, 1993 The Regents of .... to a single line (not that it really matters) .. Copyright (c) 1988 - 1993 The Regents of .... 3. CDDL HEADER and top of files (eg. SUNWopenwsman?/depend) The layout is very slight different in a few files (not that is really matters); missing line space ... # CDDL HEADER END # # # Copyright 2009 Sun Microsystems, Inc. All rights reserved. 4. Everything else looks good to me - well done -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
