Rokh, Looks good to me now. See below though ...
Paul Rokh Wang wrote: > > Thanks a lot for the comments. Would you please see my embedded reply. > I have updated the webrev according to your comments except the License > issue of prototype_com. > Webrev: http://cr.opensolaris.org/~rokh/libconfuse/. > > Paul Cunningham wrote: >> >> This mainly looks good to me, see below for a few comments ... >> >> >> Rokh Wang wrote: >>> I am porting "libconfuse". libconfuse is a configuration file parser >>> library . >>> More information can be found at http://www.nongnu.org/confuse. >>> Webrev is at "http://cr.opensolaris.org/~rokh/libconfuse/";. >> .. cut ... >> 3. usr/src/pkgdefs/SUNWlibconfuse/prototype_com *3. usr/src/pkgdefs/SUNWlibconfuse/copyright* >> You might want to add that it is the 'ISC License (ISCL)' some >> where at the top, eg ... >> 1 Copyright (c) 2002,2003,2007 Martin .... >> >> ISC License (ISCL) >> 2 >> 3 Permission to use, copy, modify, .... >> > I just wonder why I need to add the "ISC License" at the top of the > prototype_com. > Since there is CDDL header already there and this file is created by me > not from the source of libconfuse. whoops, I meant in the 'usr/src/pkgdefs/SUNWlibconfuse/copyright' file, just so readers known what licence it is. Sorry for the confusion (I blame the mouse cut/paste action) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
