Thanks Jim, Have updated as your comments.
- Regards, Jim Walker wrote: >>>>>> Robin Guo wrote: >>>>>>> I just put a code review for tcpdump package porting, >>>>>>> would you or somebody else have time to take a look on it? >>>>>>> >>>>>>> The webrev is at http://cr.opensolaris.org/~robinguo/tcpdump/ > > Just a couple nits... > > usr/src/cmd/tcpdump/METADATA > - remove these lines: > 1 # Definition of METADATA fields see > 2 # > http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines#Packagewritingguidelines-METADATA > > > 3 # Please document newly introduced fields there > > usr/src/cmd/tcpdump/install-sfw > 1 #!/usr/bin/bash > - change to: > 1 #!/usr/bin/ksh93 > > Cheers, > Jim -- Regards, Robin Guo, Xue-Bin Guo Solaris Kernel and Data Service QE, Sun China Engineering and Reserch Institute Phone: +86 10 82618200 +82296 Email: robin.guo at sun.com Blog: http://blogs.sun.com/robinguo
