On 09/09/08 16:22, Paul Cunningham wrote: > Hi, > > This mainly looks okay to me, just a few minor comments, see below .. > > Paul > > Sunanda Menon wrote: >> >> Please review the code changes for 6693315: bump mysql from 5.0.45 to >> latest 5.0.* at >> http://cr.opensolaris.org/~sunandam/6693315/ and let me know your >> comments ASAP. > > === Start of Comments ==== > > 1. pkgdefs/SUNWmysq*/pkginfo.tmpl > Do you need the pkg version on the NAME= lines? If > its not there is will make it easier to modifier > next time around.
It has the MySQL 5.0.67 version information .Don't package need to have the version information as how can the user otherwise make out which package version it is. > > 2. pkgdefs/SUNWmysq*/prototype_com > Do all these installed files need the 'write' > permission bit set? write permission is there by default for mysql owner only. > > 3. usr/src/cmd/mysql-5-0/Makefile.sfw > How about using "env - ..." instead of "env ..." so > it doesn't pick-up any random env variable. > Yes ,I can change that . > 4. everything else looks good to me > Thanks for your comments > === End of Comments ====== > -- Sunanda Menon Database Technology Group BLR03, x87098/91-80-66937098 http://blogs.sun.com/smenon
