David, See below for my comments, some of them are probably duplicates of Phadhap's comments but I have put them here anyway ...
Paul David.Fan at sun.com wrote: > Hello, > > We are porting Bonnie++ file system benchmark suite to OpenSolaris. > Please take some time to review the webrev at: > > Webrev: > http://cr.opensolaris.org/~steven84/bonnieplus/ > > RFE: > 6741736 P3 bonnie++ 1.03c disk benchmark tool to be included > into SFW consolidation > > Bonnie++ home page: > http://www.coker.com.au/bonnie++ === Start of Comments === 1. usr/src/cmd/bonnieplus/METADATA Add line for where the source code came from. 'URL: ...' 2. usr/src/cmd/bonnieplus/install-sfw You may want to apply 'Roland Mainz' comments, on other people's install-* scripts to this. You can find those comments in the sfwnv-discuss archives. BINDIR= is not used so you could delete 3. usr/src/cmd/bonnieplus/Makefile.sfw You may want to use "env - ..." rather than "env ..." so its doesn't pick-up any random env variable. 4. usr/src/pkgdefs/SUNWbonnieplus/Makefile Add line space after '#ident ...' line 5. usr/src/pkgdefs/SUNWbonnieplus/depend This looks like the default 'depend' file; if you have no other dependencies you should remove this file and add 'DATAFILES= depend' to your SUNWbonnieplus/Makefile. But have you checked you have no other dependencies with the dependency checker script? 6. usr/src/pkgdefs/SUNWbonnieplus/pkginfo Remove this files as it is generated from the pkginfo.tmpl file. 7. usr/src/pkgdefs/SUNWbonnieplus/prototype_sparc Add line space before '#ident ...' line 8. usr/src/pkgdefs/SUNWbonnieplus/prototype_i38 & usr/src/pkgdefs/SUNWbonnieplus/prototype_sparc '#ident ...' line says ... # ident "@(#)pkginfo.tmpl ... === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
