Hi Sriram, thank you for your review - wx ea/ comments addition: done - wx redelget/revisions collapsing: done - collapsing of <RM>?s into one command: done
Updated webrev: http://cr.opensolaris.org/~jinb/jruby5 thanks a lot. With best regards, Evgeny Sriram Natarajan wrote: > - You need to run 'wx ea' and add your bug number and description. > Currently, none of the to be committed files has any bug number > associated with it > - You need to run 'redelget' to collapse all your revisions > - I was mention in one of the reviews that all <RM> -rf could be > collapsed into a single command . So, passing it along to you :-) > > +clean: > + rm -rf ${JRUBY_HOME} > + rm -rf ${ANT_HOME} > + > +all: ${JRUBY_HOME} > > > thanks > sriram > > Evgeny Bessonov wrote: > >> Paul, thanks a lot for your review. >> >> Since there is a requirement of at least two code reviewers >> do somebody else has a few minutes for code review of SUNWjruby? >> >> http://cr.opensolaris.org/~jinb/jruby3/ >> >> Thanks a lot. >> With best regards. >> Evgeny >> >> >> Paul Cunningham wrote: >> >> >> >>> Evgeny, >>> >>> Evgeny Bessonov wrote: >>> >>> >>> >>>> thank you very much for explanations. >>>> >>>> I removed rm/mkdir, edited/moved back DESC >>>> and set 444 permissions for files. >>>> >>>> Updated version of JRuby webrev available here: >>>> http://cr.opensolaris.org/~jinb/jruby3/ >>>> >>> >>> This looks okay to me now >>> >>> Paul >>> >> >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>
