Siriam,
Thanks for the review. Please see comments below:
Regards,
Faramarz
Sriram Natarajan wrote:
> - You need to collapse the delta *wx redelget* (some files are not
> done while some looks ok)
Done and updated the webrev. Please let me know if there are still issues.
> - Does your build dump core ?
Not really, but I thought it's always safe to do what other people are
doing. Is it already done at a higher level makefile?
>
> +
> +VER=cmake-2.6.1
> +PREFIX=/usr
> +
> +include ../Makefile.cmd
> +
> +all: $(VER)/Makefile
> + (cd $(VER); env \
> + CC="$(CC)" \
> + CXX="$(CXX)" \
> + "LD_OPTIONS=-M $(SRC)/cmd/mapfile_noexstk -L/usr/lib
> -R/usr/lib" \
> + PATH=$(SFW_PATH) \
> + MAKE=$(GMAKE) \
> + $(GMAKE) all)
> + @find . -type f -name core -exec rm -f {} \;
> +
>
>
> If this is a cut and paste code, then you don't want this.
Are you referring to the "@find ..." part or there are other things that
should be removed such as setting env. vars. BTW,
I've already removed some of the variables.
>
> - these days, every one is being asked to have 'env -' within their
> Makefile.
Should I change the 'env' to 'env -'? I thought that since we're doing
this prior to invoking nightly, then it should not be needed.
>
> - af course, there are smart folks to give you lot more - better - review
Thanks for your time.
>
> - sriram
>
>
>
> Faramarz Jalalian wrote:
>> Hello,
>>
>> Would you please review the changes to include CMake into
>> OpenSolaris? You can find the webrev at:
>>
>> http://cr.opensolaris.org/~jalalian/cmake/
>>
>> There is "almost" no changes made to the cmake. To make installation
>> easier, the configure script is passed
>> /usr as build prefix, but cmake install target is modified to install
>> everything under sfw_stage directory so that
>> later install-sfw can pick them up and install them in the right place.
>>
>> Thanks for your time,
>>
>> Faramarz Jalalian
>> --
>> This message posted from opensolaris.org
>> _______________________________________________
>> sfwnv-discuss mailing list
>> sfwnv-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>>
