Mayuresh, Here is a few more comments, otherwise is looks okay to me. See below ..
Paul Mayuresh Nirhali wrote: > > Thanks for your comments, > I missed out on few of your comments last time, and those are addressed > in this update. > > http://cr.opensolaris.org/~wittyman/wxwidgets/ > > I request all to review the updated code changes at the link above. 1. usr/src/pkgdefs/SUNWpgadmin3/depend Copyright year need changing 2. usr/src/pkgdefs/SUNWwxwidgets-devel/prototype_i386 & usr/src/pkgdefs/SUNWwxwidgets-devel/prototype_sparc Write permission on file (f ) ? 3. usr/src/cmd/postgres/pgadmin/Makefile.sfw & usr/src/lib/wxwidgets/Makefile.sfw A 'Christopher Mi' comment you might want to apply .. > > Use the method define in Makefile.master > since you have a standard METADATA file. > > VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) > TARBALL =$(VER).tar.bz2 And a Mike.Sullivan comment you might want to apply if applicable .. > > Makefile.sfw > you really should be using $(GTAR) and the --no-same-owner > option like others. 4. usr/src/lib/wxwidgets/Makefile.sfw Add line-space before line ... 35 all: real-all Why ... 91 real-all: wxwidgets wxwidgets64 contrib32 contrib64 couldn't it just have been .. all: wxwidgets wxwidgets64 contrib32 contrib64 -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
