On 09/18/08 15:28, Paul Cunningham wrote:
> See below ...
>
> Paul
>
> Sunanda Menon wrote:
>> On 09/18/08 14:53, Paul Cunningham wrote:
>
>>> Sunanda Menon wrote:
>>>> Updated WebRev's are posted at
>>>> http://cr.opensolaris.org/~sunandam/6693315/
>>>
>>> 1. usr/src/pkgdefs/SUNWmysql5test/prototype_com
>>> Do all these files (f ) need the 'write' permission
>>> bit set?
>> The permissions are write for owner mysql as mysql owner can modify
>> the tests to customize .Others are read only mode .
>> so I think they should stay as is .
>
> okay
>
>>
>>>
>>> 2. METADATA file
>>> Do you have a METADATA file for this package?
>>> If not, you should have one.
>>> If you do, doesn't the pkg version need updating?
>>>
>> I didn't get what's a METADATA file you mean .
>
> there should be a file called usr/src/cmd/mysql-5-0/METADATA that
> contains stuff like (copied from another pkg) ...
> 1 PROGRAM: unison
> 2 PACKAGE: SUNWunison
> 3 VERSION: 2.27.57
> 4 URL : http://www.cis.upenn.edu/~bcpierce/unison
> 5 OWNER: xue-yang.yan at sun.com
> 6 LICENSE: GPLv2
> 7 SUPPORT: managed
> 8 BUGTRAQ: solaris/utility/unison
> 9 OSR: 8438
> 10 COMMENTS: No notable modifications.
>
>>
Got it ....
>>> 3. usr/src/cmd/mysql-5-0/Makefile.sfw
>> I haven't done much changes to the Makefile ,used the one that is
>> there in the gate .
>> But will try to do the changes for env and configure.
>
> Good :-)
>
BTW configure is calling /bin/ksh which is already listed in the Makefile
$(MYSQL_DIR)/config.status: $(MYSQL_DIR)/configure
(cd $(MYSQL_DIR); env $(ENVLINE32) /bin/ksh ./configure \
$(COMMON_CONFIG_OPTIONS) \
--libexecdir=$(PREFIX)/bin \
--bindir=$(PREFIX)/bin \
--libdir=$(PREFIX)/lib)
>>> You might want to apply the following ...
>>>
>>> Roland Mainz wrote:
>>> > - Please use "env - ..." and not "env ..." in
>>> > the Makefiles to make sure "configure" & "make"
>>> > only see the env variables they should really get
>>> > (and not pick-up any random env variable)
>>> > - Please use either $(SHELL) or /usr/bin/bash for
>>> > "configure" calls (so we know which one is used and
>>> > "configure" doesn't pick one itself)
>>>
>>> Christopher Mi wrote:
>>> > Use the method define in Makefile.master
>>> > since you have a standard METADATA file.
>>> >
>>> > VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
>>> > TARBALL =$(VER).tar.bz2
>>>
>>> 4. usr/src/cmd/mysql-5-0/Solaris/mysql.xml
>>> Move the Copyright lines to after the "CDDL HEADER END"
>>> header.
>>>
>> Will do .
>>
>>
>
--
Sunanda Menon
Database Technology Group
BLR03, x87098/91-80-66937098
http://blogs.sun.com/smenon
