Nils,
This looks okay to me, except for the #ident stuff.
Normally the developer would checkin their changes into their local ws
before generating the webrev - thus they get changed. But I'm not sure
how you are working outside the SWAN so you may not be able to do that.
Also as you are changing the package's Makefile.sfw file you may want to
consider doing the following (but it's okay with me if you don't for
this fix) ...
Roland Mainz wrote:
> - use "env - ..." and not "env ..." in the Makefiles
> to make sure "configure" & "make" only see the env
> variables they should really get (and not pick-up
> any random env variable)
> - use either $(SHELL) or /usr/bin/bash for "configure"
> calls (so we know which one is used and "configure"
> doesn't pick one itself)
Christopher Mi wrote:
> Use the method define in Makefile.master
> since you have a standard METADATA file.
>
> VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
> TARBALL =$(VER).tar.bz2
If there is not a METADATA file for the pkg there should be
one, and it should include lines for (early ones don't) ..
URL: <source web location>
SUPPORT: ????
BUGTRAQ: solaris/????/???
Paul
Nils Goroll wrote:
> Hi Paul and all,
>
>> 1. Makefile.sfw
>> Shouldn't the sccs #ident stuff have changed?
>
> Hm. SFWs SCM is still teamware according to the project page, so how
> should I update the SCCS tag without doing an actual checkin?
>
>> 2. prototype_com
>> Am I right in thinking that this should deliver new stuff
>> in the SUNW package, if so I think that the package's
>> prototype_com file should have changed also.
>
> Absolutely, thank you very much. Plus the change was also insufficient
> because some more files were missing.
>
> I did not actually create packages, though, and I do not have a sparc
> build environment available at the moment.
>
> I hope to have got it right now, would someone please review round two?
>
> http://cr.opensolaris.org/~nigoroll/defect3298_missing_pgxs_files-rd2/
>
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
General Dynamics Itronix Europe Ltd.
Pioneer House
Chivers Way
Histon, Cambridgeshire,
UK, CB24 9NL
Ph: +44 (0)1223 200648
FAX: +44 870 4324162
Email: paul.cunningham at tadpole.com
This email message is for the sole use of the intended
recipient(s) and may contain GDC4S confidential or privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not an intended
recipient, please contact the sender by reply email and
destroy all copies of the original message
