Nicolas Williams wrote: > On Thu, Oct 30, 2008 at 11:20:54AM +0000, Amanda Waite wrote: > >> I'd suggest making the patch file name more descriptive and suffixing it >> with '.patch'. 'Makefile.in.patch' would be ok particularly if there are >> multiple changes in the file. If the change is to address a specific >> issue then you could name the patch file according to what it fixes. At >> the very least this makes sense if you need to add another patch in the >> future. >> > > The patch file contains patches for more than one file from SQLite3. > Some SFWNV integrations have gone with one patch file per patched file; > I find that obnoxious. > > >> Otherwise, with this and the changes Paul suggested it looks fine. >> > > Thanks. (Did you update the ARC specs you wanted me to sponsor?) >
I have to work on the Apache C++ Standard Library stuff so that I know that I can support whatever I state in the Arc case. Once I've done that I'll update the wiki page and will push it out for a final review. If it's ok then it would be cool if you could sponsor it. Shouldn't take long. Cheers Amanda
