Quanhong, This looks okay to me, couple of minor comments below ..
Paul wang quanhong wrote: > > Please help reviewing the slib to be integrated into SFW consolidation. > the location is: > http://cr.opensolaris.org/~xiangshu/slib/ === Start of Comments === 1. usr/src/lib/slib/Makefile.sfw Does the 'all:' rile need "$(CCSMAKE) .... all" added so the compile part is done here? 2. usr/src/lib/slib/install-sfw I don't think you need the "MANSCRIPT=../sunman-stability" anymore, check though (someone commented in another review). === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
