Hi Steve,
Few comments
- CR#6672584 says GUN autogen need to be included into SFW consolidation
. Is it "GUN" or "GNU" ??
- SUNWautogen/prototype_i386 and SUNWautogen/prototype_sparc says
"SUNWguile - GNU guile utility" change it to SUNWautogen
~ Pradhap.D
steve xue wrote:
> Thanks to Paul and Jim's review,
> I had updated the webrev:
> http://cr.opensolaris.org/~xdstone1/webrev-guile-and-autogen/
>
> Thanks again!
> Jim Walker wrote:
>
>> steve xue wrote:
>>
>>> Please kindly do code review for my pkg porting SUNWguile and
>>> SUNWautogen:
>>>
>>> http://cr.opensolaris.org/~xdstone1/webrev-guile-and-autogen/
>>>
>>>
>> Steve,
>>
>> Here's a few comments (nits):
>>
>> usr/src/cmd/autogen/METADATA
>> 1 PROGRAM: gnu-guile
>> - change to "gnu-autogen"
>> 2 PACKAGE: SUNWguile
>> - change to "SUNWautogen"
>>
>> usr/src/cmd/guile/Makefile.sfw
>> usr/src/cmd/autogen/Makefile.sfw
>> usr/src/pkgdefs/SUNWautogen/Makefile
>> usr/src/pkgdefs/SUNWautogen/depend
>> usr/src/pkgdefs/SUNWautogen/pkginfo.tmpl
>> usr/src/pkgdefs/SUNWautogen/prototype_com
>> usr/src/pkgdefs/SUNWautogen/prototype_i386
>> usr/src/pkgdefs/SUNWautogen/prototype_sparc
>> (check other files too)
>> 1 #
>> 22 #
>> 26 #
>> - remove extra blank comment lines
>> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.Makefile
>>
>>
>> - see above
>>
>> usr/src/cmd/autogen/install-sfw
>> 3 # CDDL HEADER START
>> 4 #
>> 5 # The contents of this file are subject to the terms of the
>> 6 # Common Development and Distribution License (the "License").
>> 7 # You may not use this file except in compliance with the License.
>> 8 #
>> 9 # You can obtain a copy of the license at
>> usr/src/OPENSOLARIS.LICENSE
>> 10 # or http://www.opensolaris.org/os/licensing.
>> 11 # See the License for the specific language governing permissions
>> 12 # and limitations under the License.
>> 13 #
>> 14 # When distributing Covered Code, include this CDDL HEADER in each
>> 15 # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
>> 16 # If applicable, add the following below this CDDL HEADER, with the
>> 17 # fields enclosed by brackets "[]" replaced with your own
>> identifying
>> 18 # information: Portions Copyright [yyyy] [name of copyright owner]
>> 19 #
>> 20 # CDDL HEADER END
>> - should only be one space after "#" not two.
>>
>> usr/src/cmd/guile/install-sfw
>> 2 #
>> 22 #
>> - remove extra blank comment lines
>>
>> usr/src/pkgdefs/SUNWautogen/pkginfo.tmpl
>> 43 DESC="GNU autogen - GUN utility (5.9)"
>> - "GUN"?
>> - Maybe "GNU autogen - repetitious text utility (5.9.0)" is better?
>>
>> usr/src/pkgdefs/SUNWguile/pkginfo.tmp
>> 42 DESC="GNU guile - library support utility (1.8.4)"
>> - "GNU guile - extension language library (1.8.4)" Maybe better.
>>
>> Cheers,
>> Jim
>>
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
