Hi Paul,
>
> See below for my comments from my quick skip through ...
Thank you for your commets, see below:
>
> 1. usr/src/cmd/stunnel/Makefile.sfw
> Could you use the '--prefix=..' value predefined in
> Makefile.master? see example in ..
>
Yep, didn't think of it, but changed now.
> 2. usr/src/cmd/stunnel/stunnel.xml
> Shouldn't the copyright lines come after the
> 'CDDL HEADER END' header.
It probably should, there are lots of places where its wrong though. I have
corrected this file.
>
> 3. usr/src/pkgdefs/Makefile
> Looks as though it need resyncing with gate otherwise
> if looks as though you are deleting stuff.
Remerged.
>
> 4. usr/src/pkgdefs/SUNWstunnelr/depend
> This looks like the default 'depend', I don't
> think you meant to check it in!
>
Yeah, don't need this.
> 5. usr/src/pkgdefs/SUNWstunnelu/prototype_i386
> & usr/src/pkgdefs/SUNWstunnelu/prototype_sparc
> & usr/src/pkgdefs/SUNWstunnelr/prototype_i386
> & usr/src/pkgdefs/SUNWstunnelr/prototype_sparc
> Copyright lines are wrong and it should probably
> come after the 'CDDL HEADER END' header.
Fixed.
>
> 6. usr/src/pkgdefs/SUNWstunnelu/Makefile
> You don't need the 'DATAFILES= depend' as it has
> its own 'depend' file.
Fixed.
>
> Copyright line is of the wrong format.
>
> 7. usr/src/pkgdefs/SUNWstunnelu/depend
> Shouldn't this depend on SUNWstunnelr?
You can use stunnel without the files supplied in SUNWstunnelr, so I don't
think it depends on these files.
>
> Copyright line are wrong and it should probably
> come after the 'CDDL HEADER END' header.
>
> 8. usr/src/pkgdefs/SUNWstunnelu/pkginfo.tmpl
> Copyright year is wrong
>
Fixed.
> 9. man page
> You need to sort the sunman-stability stuff
> appropriately
Will fix.
Thanks again,
Mark
----------------------------------------------------------------------------
Mark Fenwick, Solaris Security Technologies.
TEL: +1 (650) 786 2733 (X82733) __o
Sun Microsystems Inc, Menlo Park, California. `\<,_
(*)/ (*)
----------------------------------------------------------------------------
