On Wed, Jun 11, 2008 at 12:30:11AM +0200, Roland Mainz wrote: > AFAIK this should work... > BTW: You miss "-xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1" for > CFLAGS
Herr Mainz, Please kindly refrain from suggesting that engineers use these compilation flags in their makefiles. As you are no doubt aware, this functionality is better obtained by using macros available in the existing Makefile.master as shown in my example below. On several previous occasions I have pointed this out during code review cycles on this and other public mailing lists, so I am certain this was nothing but an accidental oversight. Please accept my apologies for raising the issue at all, but I am sure you will agree that it is best for everyone that we use these global macros consistently, reducing the maintenance burden on current and future gatekeepers and providing consistency throughout our gate. One may write: C99MODE = $(C99_ENABLE) CFLAGS += $(XPG6MODE) or similar to achieve this result. As Mr. Kowalski pointed out separately, these flags may not be necessary or appropriate in all circumstances. Surely you would agree that it would be reasonable and appropriate for engineers writing new makefiles to either include appropriate standards-selection macros with an accompanying comment or document why the defaults are most appropriate for the software in question. Always your most humble and obedient servant, -- Keith M Wesolowski "Sir, we're surrounded!" Fishworks "Excellent; we can attack in any direction!"
