Hi all, Thanks to Paul for pointing out a redundant line in the Makefile.sfw file in the pam_pkcs11 source. The "CONFIGURE_OPTIONS += --prefix=$(PREFIX)" line is not needed, because "--prefix" is already prdefined in Makefile.master.
I have updated the source and new code is resync'ed at: http://cr.opensolaris.org/~hylee/pam_pkcs11/ Thanks, Huie-Ying Huie-Ying Lee wrote: > Hi all, > > Thanks to Paul, Stefan, and Wyllys for reviewing the pam_pkcs11 > source. I have updated the source to address all the review comments. > The updated source has been successfully built and tested also. > > The updated webrev is located at the same place: > http://cr.opensolaris.org/~hylee/pam_pkcs11/ > Please take a look and let me know if there is any more concerns or > questions. > > Thanks, > Huie-Ying > > > Huie-Ying Lee wrote: > >> Hi, Stefan, >> >> Thank you for your feedback. Please see my comments interspersed below. >> >> >> Stefan Teleman wrote: >> >>> Huie-Ying Lee wrote: >>> >>> >>>> Hi all, >>>> >>>> Please help review code for the pam_pkcs11 project which is to be >>>> integrated into SFWNV consolication. >>>> >>>> The webrev is located at: http://cr.opensolaris.org/~hylee/pam_pkcs11/ >>>> >>>> >> OK. I will update the arguments to the configure invocation, >> according to your suggestions. >> >> I will update the source and rebuild my gate. Will post an updated >> webrev once the testing is successfully run again. >> >> Thanks, >> Huie-Ying >> > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
