See below ... Paul
> -----Original Message----- > From: sfwnv-discuss-bounces at opensolaris.org > [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of > Bruce Rothermal > Sent: 24 June 2008 22:08 > To: sfwnv-discuss at opensolaris.org > Subject: [sfwnv-discuss] Request for code review - swig utility > > Made changes as provided on first review. > > Please see http://cr.opensolaris.org/~bruce_r/swig_try2/ and > provide any comments or changes I need to make. > === Start of additional comments === 1. usr/src/Targetdirs The indenting of your added bits still doesn't look right in the webrev (tab?) 2. usr/src/cmd/swig/Makefile.sfw 32 # (use default --prefix in Makefile.master) 33 CONFIGURE_OPTIONS += --prefix=${ROOT}/usr Why have you added the '--prefix=' when its already include in the Makefile.master (I think)? 52 $(GMAKE) -e install Is this actually installing it into the proto area? DESTDIR? 42 # LIBS=-lcurses \ 39/61 # "CFLAGS=$(CFLAGS)" \ Remove these commented out lines 3. usr/src/cmd/swig/install-swig 23 # Copyright 2007 Year wrong - and still wrong in *various* other files :-( 4. usr/src/pkgdefs/SUNWswig/pkginfo Its still in your webrev :-( - it shouldn't be 5. usr/src/pkgdefs/SUNWswig/depend Move Copyright lines to after the "CDDL HEADER END" and correct year 6. usr/src/pkgdefs/SUNWswig/Makefile 30 DATAFILES= depend Don't think this is needed as you have your own 'depend' file. Copyright year is wrong === End of additional comments =====
