Cunningham, Paul - UK wrote: > > > >> -----Original Message----- >> From: sfwnv-discuss-bounces at opensolaris.org >> [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of >> wang quanhong >> Sent: 26 June 2008 02:32 >> To: sfwnv-discuss at opensolaris.org >> Subject: [sfwnv-discuss] code review needed for bug 6718172 >> slib needs bash but SUNWslib does not depend on SUNWbash >> >> hi all, >> >> I have a bug fix for bug 6718172, please help me review it! >> You can access code review via >> http://greatwall.prc.sun.com/~qw209460/slib_webrev/. >> > > http://cr.opensolaris.org/~xiangshu/slib/ > > This looks okay to me. > I don't think you need the blank 'DATAFILES=' in the Makefile but it > probably doesn't really matter. > thanks for you comments!
I've finished update it. Please check it again. thanks again! -Quanhong > I can't see the bug report in the webrev because it has an internal SWAN > link (so just assuming you have fixed it). > > paul > > Paul >
