This looks good to me Paul
> -----Original Message----- > From: sfwnv-discuss-bounces at opensolaris.org > [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of > Amanda Waite > Sent: 25 June 2008 16:17 > To: sfwnv-discuss at opensolaris.org; webstack-discuss at opensolaris.org > Subject: [sfwnv-discuss] Code review request for Lighttpd integration > > Requesting a code review of the latest changes to the > Lighttpd integration work. The webrev is here: > http://cr.opensolaris.org/~tekgrrl/lighttp14-cr/ > > Things that have changed: > - MySQL is no longer a package dependency although the MySQL > module is built against the SFW MySQL libs (I did ask) > - Version is now 1.4.19 > - Fixed silly ident spacing issues > - Fixed hypenation and justification of the man pages > - Added server.upload-dirs directive to configuration file > - Using an SMF method file written by Roland and which uses ksh93 > - moved pid file to /var/run > > Minor issue: > - Still forced to tell the Linker where to find the MySQL > libraries with LD_LIBRARY_PATH. mysql_config --libs still > reports and incorrect path. Will discuss with the Ritu and Sunanda > > > Jyri: I'll update the path to the thread in the CR > > Thanks! > > Amanda > > -- > Amanda Waite > ISV-Engineering OSS, Sun Microsystems > Tel: +44 (0)1252 420693 > Mobile: +44 (0)7802 175732 > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
