On 10/19/07, Dermot McCluskey <Dermot.McCluskey at sun.com> wrote: > Shiv, > > - You should clearly state what version of Expect this case > introduces. In fact, I'd suggest changing the title from > "SFW: Expect to be included into SFW consolidation" to just > "Add Expect 5.43" (the consolidation name is not that > important) >
OK. Will do. > - I also suggest adding some description of what the pkg > auto-loading file, /usr/lib/expect5.43/pkgIndex.tcl, > is used for. Does it need to be in that location? Some > pkgIndex files are installed under the tcl8.4 dir, eg > /usr/lib/tcl8.4/msgcat1.3/pkgIndex.tcl. Would this be > appropriate for Expect? (On the other hand, Tk's file is > installed at the same level as Expect, so I'm not sure.) > Nice catch! Even if tk exists in that manner, moving expect into tcl's dir makes sense instead of every tcl extension having its own dir at /usr/lib level and cluttering it. I verified that with a trivial patch to pkgIndex.tcl, the new dir can be made into /usr/lib/tcl8.4/expect5.43/pkgIndex.tcl Will do. > Your next step should be to find someone in Sun to submit > your ARC case. That person should be a PSARC licensee. (I > am not a licensee, but if I become one, I'd be happy to do > this.) > Thanks. Will post on the ARC list requesting for the same. regards Shiv
