Danek Duvall wrote:
>
> http://cr.opensolaris.org/~dduvall/sfw-p7zip/
>
> Adds the p7zip utility to SFW. Review would be most appreciated.
- Not that I really care, but to clarify the process: It has been
asserted that the requirement is that putback comments must be of the
form "$CRNUM $CRSYNOPSIS". So the comment "PSARC 2007/617 p7zip 4.55"
does not match required pattern. (Of course I'd rather see rich
meaningful putback comments that actually help sustaining in the
future.. but that's a separate discussion.)
usr/src/cmd/p7zip/Makefile.sfw:
- I'm always wary of "@find . -name core -exec rm -f {} \;"
Is it really dumping core during builds? If yes, why?
usr/src/cmd/p7zip/patch:
- I'd favor a more descriptive name than "patch" for each patch. I know
there's just one here, but on the off chance there is another in some
future, it'll be annoying.
--
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
