Andre Molyneux wrote: >> An incremental second-round webrev of the idzebra package is >> available at: >> >> http://cr.opensolaris.org/~andrejm/idzebra/
usr/src/cmd/idzebra/METADATA - reduce the DESCRIPTION field way down. - remove these lines. COMMENTS are used for non-obvious things 12 idzebra depends on libyaz to deliver the /usr/lib/libyaz.so.3.0.0 13 library. usr/src/cmd/idzebra/Makefile.sfw - nice job! - make sure to use line continuations so the lines stay within 80 characters. usr/src/cmd/idzebra/sunman-stability - remove CDDL header. We align with the package license now. usr/src/pkgdefs/SUNWidzebra/pkginfo.tmpl - use this value 43 DESC="idzebra - text indexing and retrieval engine (2.0.40)" usr/src/pkgdefs/SUNWidzebra/prototype_com - can you simplify to just idzebra-config, zebraidx, zebrasrv? Unless you plan to support two version so idzebra at the same time, you shouldn't include the '-2.0' suffix in the commands. You should also remove the '-2.0' suffix from the directory names unless it requires a lot of patching. 50 f none usr/bin/idzebra-config-2.0 555 root bin 51 s none usr/bin/zebraidx=./zebraidx-2.0 52 f none usr/bin/zebraidx-2.0 555 root bin 53 s none usr/bin/zebrasrv=./zebrasrv-2.0 54 f none usr/bin/zebrasrv-2.0 555 root bin 294 d none usr/share/man 755 root bin 295 d none usr/share/man/man1 755 root bin 296 f none usr/share/man/man1/idzebra-config-2.0.1 555 root bin 297 s none usr/share/man/man1/idzebra-config.1=./idzebra-config-2.0.1 298 f none usr/share/man/man1/zebraidx-2.0.1 555 root bin 299 s none usr/share/man/man1/zebraidx.1=./zebraidx-2.0.1 300 d none usr/share/man/man8 755 root bin 301 f none usr/share/man/man8/zebrasrv-2.0.8 555 root bin 302 s none usr/share/man/man8/zebrasrv.8=./zebrasrv-2.0.8 - Are these modules only used by idzebra? 76 f none usr/lib/idzebra-2.0/modules/mod-alvis.so 555 root bin 77 f none usr/lib/idzebra-2.0/modules/mod-dom.so 555 root bin 78 f none usr/lib/idzebra-2.0/modules/mod-grs-marc.so 555 root bin 79 f none usr/lib/idzebra-2.0/modules/mod-grs-regx.so 555 root bin 80 f none usr/lib/idzebra-2.0/modules/mod-grs-xml.so 555 root bin 81 f none usr/lib/idzebra-2.0/modules/mod-safari.so 555 root bin 82 f none usr/lib/idzebra-2.0/modules/mod-text.so 555 root bin usr/src/pkgdefs/SUNWidzebra/depend 59 P SUNWcsl Core Solaris Libraries 60 P SUNWcslr Core Solaris Libraries (Root) 61 P SUNWgnutls GNU transport layer security library 62 P SUNWlxsl The XSLT library 63 P SUNWzlib The Zip compression library 64 P SUNWcsl Core Solaris, (Shared Libs) 65 P SUNWlibms Math & Microtasking Libraries (Usr) 66 P SUNWlxml The XML library 67 P SUNWlibtasn1 Tiny ASN.1 library 68 P SUNWlibgcrypt libgcrypt - cryptographic library 69 P SUNWlibgpg-error Common error codes for GnuPG, libgcrypt 70 P SUNWgnu-readline GNU readline 71 P SUNWlibyaz Z39.50/SRW/SRU client/server development toolkit You have SUNWcsl twice. Also since SUNWlibyaz depends on most of these, see if you can just be dependent on SUNWlibyaz. The other libraries should be brought in with it. I think your dependencies can be reduced. Cheers, Jim
