On 25 Aug 2009, at 18:47, Nicolas Williams <Nicolas.Williams at Sun.COM> wrote:
> On Tue, Aug 25, 2009 at 11:46:20AM +0200, Mark Phalan wrote: >> Looks generally fine. >> >> usr/src/lib/sqlite3/METADATA:7 >> Wrong URL for SOURCE_DOWNLOAD (probably should be >> http://sqlite.org/sqlite-3.6.17.tar.gz) > > Good catch. > >> Consider everything reviewed by me except >> usr/src/lib/sqlite3/update-mapfile >> >> You should get someone with more shell knowledge to review that. > > It's only intended to be run manually though. Right, and the mapfile changes look fine. I did look at it and didn't notice anything amiss. -M
