Robs wrote:
> Hi.
>
> I'd appreciate it if a couple of folks could take a look at my webrev
> for libstatgrab and provide me with feedback by 26AUG.
>
> The webrev is located here:
>
> http://cr.opensolaris.org/~robesoh/libstatgrab/
usr/src/lib/libstatgrab/METADATA
4 LICENSE: GPL
- needs to be GPLv2
usr/src/lib/libstatgrab/sunman-stability
- remove the CDDL header
- we now just keep this with the package license
usr/src/pkgdefs/SUNWlibstatgrab/depend
- this file should have at least the standard core
dependences
- Or, if only default dependencies than you do this
in the Makefile and remove the depend file.
29 include ../Makefile.com
30
31 DATAFILES= depend
32
33 .KEEP_STATE:
usr/src/pkgdefs/SUNWlibstatgrab/prototype_com
- put the files and directories in alphabetic order.
- add usr/lib/libstatgrab.so symlink
usr/src/pkgdefs/SUNWlibstatgrab/prototype_i386
usr/src/pkgdefs/SUNWlibstatgrab/prototype_sparc
- need 64bit libraries
Cheers,
Jim
