Forgot to mention. Webrev files are located at http://cr.opensolaris.org/~manjuhb/mb117111/
-manjunath Manjunath Basappa wrote: > Paul, > > Please see the new code review webrev files. I have incorporated > the corrections you have mentioned. > > Note, we are now delivering two packages, for py 2.4 and py 2.6 > from the same source file. > > Please review and let me know your feedback. > > thanks, > -manjunath > > > Paul Cunningham wrote: >> Manjunath, >> >> See comments below ... >> >> Paul >> >> Manjunath Basappa wrote: >>> >>> I am porting routes package to opensolaris /release repository. >>> >>> Please find attached the relevant documents. >>> >>> I also request a review of the source code. The webrev output is >>> located at http://cr.opensolaris.org/~manjuhb/webrev/. >> >> >> >> 1. usr/src/lib/Routes2.4/METADATA >> & usr/src/lib/Routes2.6/METADATA >> Is the PROJECT_URL: the best one to use here, is there a >> better one, may be ... >> "http://routes.groovie.org/"; >> >> Why does the SOURCE_DOWNLOAD: url point to opensolaris.org, >> shouldn't it point to the official download site for this pkg? >> >> 2. usr/src/lib/Routes2.4/Makefile.sfw >> & usr/src/lib/Routes2.6/Makefile.sfw >> Line 40, is the 'CC=$(CC)' required ? >> >> 3. usr/src/lib/Routes2.4 & usr/src/lib/Routes2.6 >> Could this have been done in a single dir, eg. >> lib/Routes (for both python 2.4 and 2.6) - the same >> tarball is used in both cases. And then the build and >> install bit done in different rules in the same Makefile.sfw? >> >> 4. usr/src/pkgdefs/SUNWpython24-routes/pkginfo (& 26) >> This should not be in the webrev as its autogenerated >> by the pkg build from pkginfo.tmpl - remove it from >> checkedin files in your workspace. >> >> 5. usr/src/lib/Routes2.6/sunman/py-routes.3 >> You may need to add the CDDL head to this! >> >> The SUNW Package name is wrong in various places >> >> Its not normal to give the full url to the source in >> a man page - see other examples in gate >> >> 6. usr/src/pkgdefs/SUNWpython24-routes/Makefile & 26 >> Copyright year is wrong - its also wrong is various >> other files!! >> >> 7. usr/src/pkgdefs/SUNWpython24-routes/copyright & 26 >> Should this say what licence it is! >> >> 8. pkgdefs/SUNWpython24-routes & 26 >> Could these have been delivered as a single package? >> >> 9. usr/src/pkgdefs/SUNWpython24-routes/depend & 26 >> This also needs all the core pkgs in it, ie. those in the >> default depend file. >> >> Is SUNWPython 2.4 and 2.6 delivered in the same pkg? >> >> 10. usr/src/pkgdefs/SUNWpython24-routes/pkginfo.tmpl & 26 >> Add the pkg version to the end of the DESC= line, eg... >> DESC="............. (1.10.3) >> >> 11. usr/src/pkgdefs/SUNWpython24-routes/prototype_sparc & 26 >> & SUNWpython26-routes/prototype_i386 >> SUNW pkg name is wrong >> >> END > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
