Hi Stefan,

See comments below from my quick skip through ...

Paul

Stefan Teleman wrote:
> Webrev at:
> 
> http://cr.opensolaris.org/~steleman/6751764/

1. usr/src/cmd/subversion/install-sfw
     & usr/src/pkgdefs/SUNWsvn/prototype_com
    You are installing files with the write-permission bit set,
    I think you should remove that permission from all files

2. usr/src/cmd/subversion/Makefile.sfw
     & usr/src/cmd/subversion/install-sfw
    Use the pkg-name and pkg-version extracted from the METADATA
    instead of hard coding it (VER=...).

3. usr/src/cmd/subversion/install-sfw
    Add 'set -o errexit' so it stops at first error

4. usr/src/lib/libneon
    Why is there this stuff in this webrev?

END

Reply via email to