George, Looks mainly good to me, see below for a few comments ...
Paul George Vasick wrote: > > I am looking for reviewers for the upgrade of dbx to version 6.8. > Support for debugging 64 bit processes is also included: > > http://cr.opensolaris.org/~gvasick/6838651/ 1. usr/src/cmd/gdb/Makefile.sfw Lines 81 & 92, you could probably use the prefix= value from Makefile.master here Lines 69-72, do you actually need to do this protofix, doesn't install-sfw set them correctly ? 2. usr/src/cmd/gdb/install-sfw Line 1, it should probably be ksh93 3. usr/src/cmd/gdb/patch.gdb.auxv.c & patch.gdb.solib-svr4.c Would it be better to name this gdb.auxv.patch or something like that ? 4. usr/src/pkgdefs/SUNWgdb/copyright Does this need the sun disclaimer header changed for GPLv3? 5. usr/src/pkgdefs/SUNWgdb/pkginfo.tmpl Cosmetic: you could put the version number at the end of the DESC= line in brackets, so it consistent with how most of the later gate pkgs are, ie. DESC="........... (x.x)"
