Danek, This looks mainly okay to me, but you might want to consider the comments below ...
Paul Danek Duvall wrote: > I'm putting in an update to zsh, to the latest available, as well as > updating some of the Solaris-specific completion routines (and introducing > one for pkg(5)). I'm also fixing a couple of bugs that require the > addition of some /etc/files ... due to the fact that we're no longer > shipping an SVr4-based WOS, there's little point in maintaining a root/usr > split for packages, so I've eliminated audit_pkg and just stuffed the /etc > files directly into SUNWzsh. I've cleared this with Comay, Norm, and Mike. > > Here's the webrev: > > http://cr.opensolaris.org/~dduvall/zsh-4310/ 1. usr/src/cmd/zsh/Completion/Solaris/Command/_zoneadm Is commented-out line 6 required? 2. usr/src/cmd/zsh/Completion/Solaris/Command/_svcadm Are commented-out lines 57-63 required? 3. usr/src/cmd/zsh/Completion/Unix/Command/_zfs Should it contain "TODO"s, lines 16 & 24 ? 4. usr/src/cmd/zsh/Completion/Unix/Command/_zpool + usr/src/cmd/zsh/Completion/Solaris/Command/_dladm + maybe others Does it need line 2 (comment line)? -- Paul Cunningham Software Engineer
