Hi Milan, This looks mainly okay to me, but see below for a few observations ..
Paul Milan Cermak wrote: > Hi all, > I'd like to ask for a code review of the CR 6832369 "Midnight Commander > should be updated" > > Webrev: http://cr.opensolaris.org/~mcermak/sfwnv-6832369/ 1. usr/src/pkgdefs/SUNWgnu-mc/prototype_com Observation: just wondered why you changed the top few files adding the leading 0 to the permissions? 2. UTF8 Observation: Is the utf8 stuff that was patched in the previous version now in the source tarball ? 3. usr/src/cmd/mc/install-sfw Observation: Lines 46-50, do you need these mkdir's as they should already be defined in Targetdirs, and hence already created?
