On Fri, Jul 27, 2012 at 2:10 PM, Liu Yuan <namei.u...@gmail.com> wrote: > On 07/27/2012 02:02 PM, Yunkai Zhang wrote: >> In fact, my fist inner version return EXIT_XXX in send_light_req(), >> but I found that EXIT_xxx code defined in exits.h, they seems not >> appropriate for library functions (compare to exe_req()/send_req() and >> other system calls).Library functions usually return errno instead of >> EXIT code. > > Then simply return -1 for error case. I think we already use eprintf to > print error message, it is fine for now to only return EXIT_FAILURE for > all collie command.
Ok, I'll give v3 later. > > Thanks, > Yuan -- Yunkai Zhang Work at Taobao -- sheepdog mailing list sheepdog@lists.wpkg.org http://lists.wpkg.org/mailman/listinfo/sheepdog
