On 2012年08月24日 12:38, MORITA Kazutaka wrote: > At Fri, 24 Aug 2012 10:56:35 +0800, > levin li wrote: >> >> From: levin li <xingke....@taobao.com> >> >> Since we already send vdi copy list in get_vdis(), there's no >> need to send the vdi_inuse bitmap any more, without it we can >> send less data as the length of vdi copy list is variable and >> it contains the vid just as vdi_inuse does. >> >> Signed-off-by: levin li <xingke....@taobao.com> >> --- >> sheep/group.c | 37 ++++++++++++++++--------------------- >> sheep/ops.c | 4 +++- >> sheep/sheep_priv.h | 3 +-- >> sheep/vdi.c | 15 +-------------- >> 4 files changed, 21 insertions(+), 38 deletions(-) > > SD_OP_READ_VDIS is also used by qemu. Can we keep consistency rather > than simplifying it a bit? > > Thanks, > > Kazutaka >
Well, I didn't notice that, I'd like to update this patch to add a new local operation for sheep and collie to read the vdi list rather than using SD_OP_READ_VDIS, the bitmap is not so small, as I calculated the size of vdi_inuse is 2M, not transferring it not only simplify the code, but also can save network resource, what do you think about it? thanks, levin -- sheepdog mailing list sheepdog@lists.wpkg.org http://lists.wpkg.org/mailman/listinfo/sheepdog
