2013/12/11 Liu Yuan <namei.u...@gmail.com> > On Wed, Dec 11, 2013 at 10:59:27AM +0800, Robin Dong wrote: > > Why not adding the check in gateway_forward_request() ? I think we should > > check the copy number before send forward the request out. > > I think it is better to check the request as early as possible, no? This is > pointless to run the request down to gateway_forward_request(), which is > queued > on the work queue and might need some time to be called and then return the > error to the client. > > What is the benefit to check inside the gateway_forward_request instead of > the > approch of this patch? >
Sorry，I misunderstand the gateway_forward_request() and queue_gateway_request()，your code is correct. Reviewed-by: Robin Dong <san...@taobao.com> > Thanks > Yuan > -- -- Best Regard Robin Dong
-- sheepdog mailing list sheepdog@lists.wpkg.org http://lists.wpkg.org/mailman/listinfo/sheepdog
