At Thu, 30 Jan 2014 12:47:49 +0800, Liu Yuan wrote: > > @@ -254,6 +267,11 @@ int default_init(void) > return for_each_object_in_wd(init_objlist_and_vdi_bitmap, true, NULL); > } > > +static inline bool stale_path(const char *path) > +{ > + return !!strstr(path, "stale"); > +} > +
The function name should be is_stale_path()? I got the following warnings. plain_store.c: In function ‘default_link’: plain_store.c:455:23: warning: declaration of ‘stale_path’ shadows a global declaration [-Wshadow] plain_store.c:270:20: warning: shadowed declaration is here [-Wshadow] plain_store.c: In function ‘move_object_to_stale_dir’: plain_store.c:523:23: warning: declaration of ‘stale_path’ shadows a global declaration [-Wshadow] plain_store.c:270:20: warning: shadowed declaration is here [-Wshadow] Thanks, Kazutaka -- sheepdog mailing list sheepdog@lists.wpkg.org http://lists.wpkg.org/mailman/listinfo/sheepdog