Modified: incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamAtomConverterTest.java URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamAtomConverterTest.java?rev=727033&r1=727032&r2=727033&view=diff ============================================================================== --- incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamAtomConverterTest.java (original) +++ incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamAtomConverterTest.java Tue Dec 16 03:51:28 2008 @@ -19,6 +19,7 @@ import com.google.common.collect.Lists; import com.google.common.collect.Maps; + import com.google.inject.Guice; import com.google.inject.Injector; @@ -163,7 +164,7 @@ } public void testMapToXml() throws XmlException { - Map<String, String> m = new LinkedHashMap<String, String>(); + Map<String, String> m = Maps.newLinkedHashMap(); m.put("key1", "value1"); m.put("key2", "value2"); String xml = beanXmlConverter.convertToString(m); @@ -185,7 +186,7 @@ } public void testEmptyList() throws XmlException { - List<String> empty = new ArrayList<String>(); + List<String> empty = Lists.newArrayList(); String xml = beanXmlConverter.convertToString(empty); XmlUtil.parse(xml); String expectedXml = "<feed xmlns=\"http://ns.opensocial.org/2008/opensocial\" " @@ -197,10 +198,11 @@ assertEquals(StringUtils.deleteWhitespace(expectedXml), StringUtils .deleteWhitespace(xml)); - List<List<String>> emptyLists = new ArrayList<List<String>>(); - emptyLists.add(new ArrayList<String>()); - emptyLists.add(new ArrayList<String>()); - emptyLists.add(new ArrayList<String>()); + List<List<String>> emptyLists = Lists.newArrayList(); + List<String> emptyList = Lists.newArrayList(); + emptyLists.add(emptyList); + emptyLists.add(emptyList); + emptyLists.add(emptyList); xml = beanXmlConverter.convertToString(emptyLists); XmlUtil.parse(xml); expectedXml = "<feed xmlns=\"http://ns.opensocial.org/2008/opensocial\" " @@ -215,7 +217,7 @@ } public void testElementNamesInList() throws XmlException { - List<Activity> activities = new ArrayList<Activity>(); + List<Activity> activities = Lists.newArrayList(); activities.add(activity); activities.add(activity); activities.add(activity);
Modified: incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamConverterTest.java URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamConverterTest.java?rev=727033&r1=727032&r2=727033&view=diff ============================================================================== --- incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamConverterTest.java (original) +++ incubator/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamConverterTest.java Tue Dec 16 03:51:28 2008 @@ -167,7 +167,7 @@ } public void testMapToXml() throws XmlException { - Map<String, String> m = new LinkedHashMap<String, String>(); + Map<String, String> m = Maps.newLinkedHashMap(); m.put("key1", "value1"); m.put("key2", "value2"); String xml = beanXmlConverter.convertToString(m); @@ -181,17 +181,18 @@ } public void testEmptyList() throws XmlException { - List<String> empty = new ArrayList<String>(); + List<String> empty = Lists.newArrayList(); String xml = beanXmlConverter.convertToString(empty); XmlUtil.parse(xml); String expectedXml = "<response><list/></response>"; assertEquals(StringUtils.deleteWhitespace(expectedXml), StringUtils .deleteWhitespace(xml)); - List<List<String>> emptyLists = new ArrayList<List<String>>(); - emptyLists.add(new ArrayList<String>()); - emptyLists.add(new ArrayList<String>()); - emptyLists.add(new ArrayList<String>()); + List<List<String>> emptyLists = Lists.newArrayList(); + List<String> emptyList = Lists.newArrayList(); + emptyLists.add(emptyList); + emptyLists.add(emptyList); + emptyLists.add(emptyList); xml = beanXmlConverter.convertToString(emptyLists); XmlUtil.parse(xml); expectedXml = "<response><list.container>" + " <list/>" + " <list/>" @@ -201,7 +202,7 @@ } public void testElementNamesInList() throws XmlException { - List<Activity> activities = new ArrayList<Activity>(); + List<Activity> activities = Lists.newArrayList(); activities.add(activity); activities.add(activity); activities.add(activity);
