I feel like we won't need non-minified code for a while but when we do I don't see #2 as being a bad option. #3 sounds horrendous to me
- Cassie On Fri, Mar 7, 2008 at 2:30 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > I talked with Mike about this on Wednesday. There are a few possibilities: > > 1. Implement dynamic minification in shindig using Rhino, or possibly even > the caja parser if it makes sense. > 2. Have caja packaged to include both debug and minified versions of the > files > 3. Keep what we have and be careful about making sure that we always keep > what's checked into shindig up to date with what's in caja. > 4. Ignore the issue for now and just assume that by the time we're using > caja across the board, we'll be running our feature javascript through it > anyway and can minify it there. > > On Thu, Mar 6, 2008 at 5:18 PM, Bruno Bowden <[EMAIL PROTECTED]> wrote: > > > Shindig should be able to use Caja in debug mode with non-minified > > versions > > of those added files. I'm not sure of the correct way to do that. > > > > On Thu, Mar 6, 2008 at 5:09 PM, Mike Samuel <[EMAIL PROTECTED]> > wrote: > > > > > Attached is a patch. > > > > > > Kevin suggested that it'd be a good idea to get the added files from > the > > > Caja JAR instead of copying them into the shindig source tree. > > > He also suggested consolidating and minifying those files in the JAR > > since > > > shindig doesn't do runtime minification. > > > > > > That's a great idea but I'd like to do that in a separate change. I > > will > > > talk to Mike Stay on Caja to make sure the jar contains those files or > a > > > minified JS bundle in future versions. > > > > > > > > > > > > features/caja contains runtime support for Cajoling of gadgets. See > > > code.google.com/p/google-caja > > > > > > DOMita provides a partial fake DOM Level 2 implementation that gates > > > gadget access to the DOM > > > > > > This change adds DOMita and updates the html sanitizer used when the > > Caja > > > feature is enabled. > > > > > > Some of the functionality in container.js is redundant with domita, > and > > is > > > removed, but none of that functionality should be triggered when the > > Caja > > > feature is disabled. > > > > > > > > > > > > > > > cheers, > > > mike > > > > > > > > > -- > ~Kevin >
