On Tue, Mar 25, 2008 at 10:09 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > Might I pester some of you guys for feedback on this?
Looks OK to me, maybe slightly more obscure than CrossServletState. I had to look up ServletContextListener, but it doesn't look like most people will need to touch that code. > I'm working on an updated patch that addresses some remaining clunkiness in > RPC. Still unsure how to address Brian Eaton's security stuff since he > hasn't sent us a patch with it yet. There isn't much change from the current state of affairs. Refactoring a few classes so they implement RemoteContentFetcher took around an hour this morning, and I think the code is cleaner for it. I still need the factory methods in CrossServletState. If anything they are getting more complex because of OAuth dependencies on a backend data store. I'm not sure how best to map this to Guice. Maybe inject a factory class? Would that defeat the purpose? If you can get a suitable replacement for GadgetSigner and makeSignedFetchRequestSigner working with Guice I'll probably have an easy merge. Cheers, Brian
