[
https://issues.apache.org/jira/browse/SHINDIG-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585202#action_12585202
]
Brian Eaton commented on SHINDIG-159:
-------------------------------------
Wow. Remind me not to use e-mail to respond to JIRA comments any more.
Somewhere along the way the comments I was replying too got lost.
To summarize the major changes in this revision:
- created a generic mechanism for chained fetchers to append JSON to responses.
ProxyHandler now knows almost nothing about OAuth, which is good, but it also
makes it harder for someone to tell where these magic JSON values get created.
- moved bootstrapping of consumer keys and secrets. It was done in
OAuthFetcher. Now it's in BasicGadgetOAuthTokenStore, to make it clearer that
this is more suitable for a quick demo than production code. (We fetch and
parse every OAuth gadget spec when the server starts. It doesn't scale.)
I've also addressed your formatting/style requests, I think. Let me know if I
misunderstood.
Quick explanation of the storage of oauth tokens (this is all Dirk's code, by
the way...)
OAuthStore: most basic interface for storing OAuth tokens. Everybody will need
to hook this up to their persistent store.
BasicOAuthStore: in memory implementation of OAuthStore. Useful for demos and
testing, not production.
GadgetOAuthTokenStore: adds functionality on top of an OAuthStore, such as
moving metadata from gadget specs into the OAuthStore. This code is intended
for production use.
BasicGadgetOAuthTokenStore: subclass of GadgetOAuthTokenStore that bootstraps a
store based on the config/oauth.js file. Not intended for production use, but
useful for demos and testing.
> OAuth support in Shindig
> ------------------------
>
> Key: SHINDIG-159
> URL: https://issues.apache.org/jira/browse/SHINDIG-159
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Brian Eaton
> Attachments: full-oauth.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
