[
https://issues.apache.org/jira/browse/SHINDIG-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589371#action_12589371
]
Kevin Brown commented on SHINDIG-197:
-------------------------------------
Some comments:
- If we're renaming RemoteContentFetcher (which I agree with), I'd prefer
HttpRequest and HttpResponse over RemoteContentRequest and RemoteContent.
- Order of imports looks wrong on some of the files. org.apache.shindig stuff
should probably always be first. Maybe we need to clarify in the style guide.
- If we're introducing custom interfaces instead of doing everything as a
RemoteContentFetcher, we should drop some of those annotations.
@ProxiedContentFetcher is no longer necessary, for example. The entire optional
injection can actually be discarded. This will require implementations
potentially implementing more interfaces, though.
- The Auth type enumeration is good, but I don't think it belongs on Preload.
It should probably be org.apache.shindig.oauth.AuthType or something along
those lines. Preload is probably the least obvious consumer of the authz types.
- Class comments shouldn't have authorship info
- Missing apache license headers from some new files
- Why ContentCache and not just a generic Cache<Key, Value> ?
- For <Preload> the authz should default to "none". It shouldn't be required
(isn't that how you proposed it in the spec?)
- No luck getting the Guice servlet package?
> Add support for authenticated/signed preloads. Refactor caching code to allow
> for caching of same.
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-197
> URL: https://issues.apache.org/jira/browse/SHINDIG-197
> Project: Shindig
> Issue Type: New Feature
> Components: Features (Javascript), Gadget Rendering Server (Java),
> Gadget Rendering Server (PHP)
> Reporter: Louis Ryan
> Assignee: Louis Ryan
> Attachments:
> Introduce_support_for__authenticated_preloads_Refactored_caching_to_allow_for_caching_of_signed_requests_(lots_of_cleanup).patch
>
>
> This is a pretty extensive change, the first part adds support for an 'authz'
> attribute to the Preload element as part of the spec. THIS IS A SPEC
> ENHANCEMENT!
> The second part adds a reworking of the Caching code to separate the caching
> interface from the fetcher interface, encapsulate cacheability checking and
> generally make to code cleaner and more manageable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
