[
https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594358#action_12594358
]
Dan Lester commented on SHINDIG-60:
-----------------------------------
Gary, thanks so much for consolidating my work so far - I'll take a look
shortly.
Kevin (and Gary), I imagined that ErrorMsg was supposed to convey only feed
problems, not processing errors. If the proxy component functions perfectly,
but there is a problem with the feed RSS, perhaps that should be returned as a
'success' to all Shindig components, but the JSON object that ends up with the
gadget contains an ErrorMsg item indicating the feed problem.
Let's say the proxy component blows up for some internal error, then of course
that should come back in the normal Shindig way.
I haven't studied the relevant specs in detail at this stage, and I'm not
trying to start an argument! Happy to believe your interpretation, but I just
wanted to prompt you to consider this possible distinction. Just because the
member is called "Error" doesn't mean it's really an "error" in the Shindig
sense...
As I see it, Kevin's interpretation provides for better consistency with the
other uses of makeRequest, although fails to suppose backward capability for
Gadgets - although that could still be built into the Javascript when
_IG_FetchFeedAsJson is used.
> Shindig does not properly support the FEED content type as defined by the
> gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java),
> Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch,
> ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json
> in the same way that the JSON contentType does. It should instead return a
> structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
