Ok tweaked eclipse a bit, re-formated the whole thing to remove the
whitespace before EOL's, should be all good on the PHP side now
ref: http://svn.apache.org/viewvc?view=rev&revision=654115
-- Chris
On May 7, 2008, at 12:50 PM, Chris Chabot wrote:
No fair ! :-)
if you look at the php patches it's all:
- <tab>
+<nothing>
between class functions.
Zend studio for eclipse puts indentation between class functions, so
that when you start typing your new function there, it's in the
right spot right away ... behavior i'm rather fond of tbh :-) But i
guess i could go dig in the options and see where i can turn it off
if it's a problem :)
-- Chris
On May 7, 2008, at 12:37 PM, Cassie wrote:
btw - if you look at santiago's diff the social-api stuff is 99%
clean.
kevin, louis and chris - i think you need to fix your IDEs :)
On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <[EMAIL PROTECTED]
>
wrote:
http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
<http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
>
lists a big diff that would cleanup the following conditions:
- whitespace (blanks or tabs) before EOL [1]
- spaces before tabs in indentation
I won't commit something that intrusive to the main line of
development,
as it would be likely to cause lots of conflicts for no clear reason
Not a biggie, just in case people wans to clean up this kind of
things
before starting work on those files, etc.
I could actually commit this, but I won't do without a clear
permission,
as it is very likely to conflict a lot. I have been doing the
exercise
every so and so, and the number of "affected" files does not seem
to be
going down, rather the opposite. I don't open an issue with the
patch
because the patch changes too often to be really useful.
Regards
Santiago
[1] I'm not so sure that a space before EOL is really evil in plain
text, but a number of tools bark on it anyhow. I think spaces before
tabs should be cleaned, that would be a way minor patch.
--
Santiago Gala
http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/>
