Author: etnu
Date: Wed Jun 11 11:24:07 2008
New Revision: 666765
URL: http://svn.apache.org/viewvc?rev=666765&view=rev
Log:
Relaxed visibility of proxy constants to make integration tests a bit less
fragile.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java?rev=666765&r1=666764&r2=666765&view=diff
==============================================================================
---
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
(original)
+++
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
Wed Jun 11 11:24:07 2008
@@ -56,18 +56,19 @@
* Unlike ProxyHandler, this may perform operations such as OAuth or signed
fetch.
*/
public class MakeRequestHandler extends ProxyBase{
- protected static final String UNPARSEABLE_CRUFT = "throw 1; < don't be evil'
>";
- protected static final String POST_DATA_PARAM = "postData";
- protected static final String METHOD_PARAM = "httpMethod";
- protected static final String SECURITY_TOKEN_PARAM = "st";
- protected static final String HEADERS_PARAM = "headers";
- protected static final String NOCACHE_PARAM = "nocache";
- protected static final String SIGN_VIEWER = "signViewer";
- protected static final String SIGN_OWNER = "signOwner";
- protected static final String CONTENT_TYPE_PARAM = "contentType";
- protected static final String NUM_ENTRIES_PARAM = "numEntries";
- protected static final String DEFAULT_NUM_ENTRIES = "3";
- protected static final String GET_SUMMARIES_PARAM = "getSummaries";
+ // Relaxed visibility for ease of integration. Try to avoid relying on these.
+ public static final String UNPARSEABLE_CRUFT = "throw 1; < don't be evil' >";
+ public static final String POST_DATA_PARAM = "postData";
+ public static final String METHOD_PARAM = "httpMethod";
+ public static final String SECURITY_TOKEN_PARAM = "st";
+ public static final String HEADERS_PARAM = "headers";
+ public static final String NOCACHE_PARAM = "nocache";
+ public static final String SIGN_VIEWER = "signViewer";
+ public static final String SIGN_OWNER = "signOwner";
+ public static final String CONTENT_TYPE_PARAM = "contentType";
+ public static final String NUM_ENTRIES_PARAM = "numEntries";
+ public static final String DEFAULT_NUM_ENTRIES = "3";
+ public static final String GET_SUMMARIES_PARAM = "getSummaries";
private final SecurityTokenDecoder securityTokenDecoder;
private final ContentFetcherFactory contentFetcherFactory;
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java?rev=666765&r1=666764&r2=666765&view=diff
==============================================================================
---
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
(original)
+++
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
Wed Jun 11 11:24:07 2008
@@ -32,9 +32,9 @@
* Base class for proxy-based handlers.
*/
public abstract class ProxyBase {
- protected static final String URL_PARAM = "url";
- protected static final String REFRESH_PARAM = "refresh";
- protected static final String GADGET_PARAM = "gadget";
+ public static final String URL_PARAM = "url";
+ public static final String REFRESH_PARAM = "refresh";
+ public static final String GADGET_PARAM = "gadget";
// Public because of rewriter. Rewriter should be cleaned up.
public static final String REWRITE_MIME_TYPE_PARAM = "rewriteMime";
