[ 
https://issues.apache.org/jira/browse/SHINDIG-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605804#action_12605804
 ] 

Brian Eaton commented on SHINDIG-383:
-------------------------------------

I've added tests for preloading, oauth, signed fetch, various content types, 
etc...

There are no tests for window.ActiveXObject.

There are no tests for %rawurl%.

Tests of several areas are lacking depth.

This is still using a strict mock, because that was easier to write and I don't 
think it will cause problems for these test cases.  It might even be useful for 
some of the more stateful tests, e.g. OAuth.

I'll let this sit in Jira for a day or two to see if there are more comments.  
Assuming no one objects, I'll check it in as is.

> unit tests for io.js
> --------------------
>
>                 Key: SHINDIG-383
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-383
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>            Reporter: Brian Eaton
>         Attachments: iotests-v2.patch
>
>
> We should have unittests for io.js.  I've put together a (very rough) patch 
> for that based on a mocked out XMLHTTPRequest object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to