[ 
https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607699#action_12607699
 ] 

Kevin Brown commented on SHINDIG-342:
-------------------------------------

Looks good, although I'll reiterate that I don't think tests should be 
verifying the message on an exception -- they should be verifying the type of 
the exception, or possibly some enumeration value in a pinch.

Oh -- and can we fix the tests to not depend on a static file name? It makes it 
hard to run tests in many situations (like an IDE).

> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
>                 Key: SHINDIG-342
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-342
>             Project: Shindig
>          Issue Type: Sub-task
>            Reporter: Kevin Brown
>            Assignee: Brian Eaton
>         Attachments: oauth08.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to