On Jul 10, 2008, at 12:11 PM, Kevin Brown wrote:

On Thu, Jul 10, 2008 at 8:33 AM, Paul Lindner <[EMAIL PROTECTED]> wrote:

I'd appreciate it if someone could look at SHINDIG-440 and validate the changes there.. If we go ahead with the patch there we'll also want to document the list of bindings that can be customized, perhaps with a sample
Guice module..


My main issue with ImplementedBy is that it makes it's fairly "magical" for
users. I'd rather go with an overrideModule solution to the problem.



I'm open to switching to override modules in the future, perhaps when the next version of Guice is finally released?

We'd also want to review the module design at that point.

For now I'm very happy with these changes, it makes integration much, much easier.

Paul Lindner
[EMAIL PROTECTED]



Reply via email to