Wanted to revive the thread on using code review tools with Shindig. There is a really good tool up at http://codereview.appspot.com, and I'd like to discuss whether it is OK to use for reviews. - Sample diff: http://codereview.appspot.com/5245/diff/1/2 - Full review: http://codereview.appspot.com/5245
Here's my quick list of pluses and minuses... Good: - Ability to email cc on reviews, so that the official record is still on shindig-dev@ - Threaded comment support, very clean inline display of diffs - Open source, so we can run our own instance if we need to customize - But hosted for now, so we can easily try it out - Doesn't require a login to view patches and comments Bad: - Hosted on appspot, which requires a Google login to comment. We can change this if we run our own hosted version. How do people feel about trying this out on an experimental basis? Evan P.S. Does anyone know what the URL format is to access for revisions of files in svn? It looks like the diffs only work against the most recent version in SVN, as it is using http://svn.apache.org/repos/asf/incubator/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java ?*rev=690667* as the URL format, which doesn't actually get the bolded revision.
